Counted keyword randomized testing #121462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-powers
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
reviewed
Jan 31, 2025
|
|
||
| this.valueGenerator = arrays.wrapper().compose(nulls.wrapper()).apply(() -> { | ||
| if (previousStrings.size() > 0 && ESTestCase.randomBoolean()) { | ||
| return ESTestCase.randomFrom(previousStrings); |
Contributor
There was a problem hiding this comment.
We should not directly use ESTestCase here, it should be hidden inside DataSource. You can probably define a generic "repeating" wrapper but i haven't looked too closely.
| } | ||
| } | ||
|
|
||
| return counts.isEmpty(); |
lkts
approved these changes
Feb 3, 2025
jordan-powers
added a commit
that referenced
this pull request
Feb 4, 2025
As a result of the randomized testing enabled in #121462, we found that we currently fail to parse documents with arrays of objects containing counted_keyword fields. This PR fixes this issue by using a custom docvalues field to store the count instead of the built-in lucene BinaryDocValues. This custom CountsBinaryDocValuesField has logic to handle multiple values for the same field.
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Feb 4, 2025
This patch adds the needed data generator and source matcher to include counted_keyword fields in our randomized testing. This patch also updates the source matcher such that field-specific matchers are checked before the generic matcher is used. It seems that this is the correct behavior, and the only reason the generic matcher was checked first was as a workaround for issue elastic#111916, which is now closed. (cherry picked from commit 061920b)
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 4, 2025
As a result of the randomized testing enabled in #121462, we found that we currently fail to parse documents with arrays of objects containing counted_keyword fields. This PR fixes this issue by using a custom docvalues field to store the count instead of the built-in lucene BinaryDocValues. This custom CountsBinaryDocValuesField has logic to handle multiple values for the same field. (cherry picked from commit 13b743c)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
This patch adds the needed data generator and source matcher to include counted_keyword fields in our randomized testing. This patch also updates the source matcher such that field-specific matchers are checked before the generic matcher is used. It seems that this is the correct behavior, and the only reason the generic matcher was checked first was as a workaround for issue #111916, which is now closed. (cherry picked from commit 061920b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the needed data generator and source matcher to include
counted_keywordfields in our randomized testing.This patch also updates the source matcher such that field-specific matchers are checked before the generic matcher is used. It seems that this is the correct behavior, and the only reason the generic matcher was checked first was as a workaround for issue #111916, which is now closed.